From 5774ce3b9e48a12beac4e55091ac782f8ccefc5a Mon Sep 17 00:00:00 2001 From: Thulinma Date: Tue, 10 Nov 2020 17:02:21 +0100 Subject: [PATCH] Fixed segfault in StartPiped when out of file descriptors --- lib/procs.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/procs.cpp b/lib/procs.cpp index a1aa91d5..24249a0c 100644 --- a/lib/procs.cpp +++ b/lib/procs.cpp @@ -311,15 +311,15 @@ pid_t Util::Procs::StartPiped(const char *const *argv, int *fdin, int *fdout, in devnull = open("/dev/null", O_RDWR); if (devnull == -1){ ERROR_MSG("Could not open /dev/null for process %s, reason: %s", argv[0], strerror(errno)); - if (*fdin == -1){ + if (fdin && *fdin == -1){ close(pipein[0]); close(pipein[1]); } - if (*fdout == -1){ + if (fdout && *fdout == -1){ close(pipeout[0]); close(pipeout[1]); } - if (*fderr == -1){ + if (fderr && *fderr == -1){ close(pipeerr[0]); close(pipeerr[1]); }