Improved selectDefaultTracks function to give feedback on selection changes.

This commit is contained in:
Thulinma 2018-07-04 11:43:29 +02:00
parent a984243d56
commit 9723159592
4 changed files with 35 additions and 9 deletions

View file

@ -255,16 +255,31 @@ namespace Mist{
} }
} }
void Output::selectDefaultTracks(){ /// Automatically selects the tracks that are possible and/or wanted.
/// Returns true if the track selection changed in any way.
bool Output::selectDefaultTracks(){
if (!isInitialized){ if (!isInitialized){
initialize(); initialize();
if (!isInitialized){return;} if (!isInitialized){return false;}
} }
//First, back up and wipe the existing selections, if any.
std::set<unsigned long> oldSel = selectedTracks;
selectedTracks.clear();
bool autoSeek = buffer.size();
uint64_t seekTarget = currentTime();
//check which tracks don't actually exist //check which tracks don't actually exist
std::set<unsigned long> toRemove; std::set<unsigned long> toRemove;
for (std::set<unsigned long>::iterator it = selectedTracks.begin(); it != selectedTracks.end(); it++){ for (std::set<unsigned long>::iterator it = selectedTracks.begin(); it != selectedTracks.end(); it++){
if (!myMeta.tracks.count(*it)){ if (!myMeta.tracks.count(*it)){
toRemove.insert(*it); toRemove.insert(*it);
continue;
}
//autoSeeking and target not in bounds? Drop it too.
if (autoSeek && myMeta.tracks[*it].lastms < seekTarget - 6000){
toRemove.insert(*it);
} }
} }
//remove those from selectedtracks //remove those from selectedtracks
@ -344,6 +359,7 @@ namespace Mist{
if (myMeta.live){ if (myMeta.live){
for (std::map<unsigned int, DTSC::Track>::reverse_iterator trit = myMeta.tracks.rbegin(); trit != myMeta.tracks.rend(); trit++){ for (std::map<unsigned int, DTSC::Track>::reverse_iterator trit = myMeta.tracks.rbegin(); trit != myMeta.tracks.rend(); trit++){
if ((!byType && trit->second.codec == strRef.substr(shift)) || (byType && trit->second.type == strRef.substr(shift)) || strRef.substr(shift) == "*"){ if ((!byType && trit->second.codec == strRef.substr(shift)) || (byType && trit->second.type == strRef.substr(shift)) || strRef.substr(shift) == "*"){
if (autoSeek && trit->second.lastms < seekTarget - 6000){continue;}
selectedTracks.insert(trit->first); selectedTracks.insert(trit->first);
found = true; found = true;
if (!multiSel){break;} if (!multiSel){break;}
@ -352,6 +368,7 @@ namespace Mist{
}else{ }else{
for (std::map<unsigned int, DTSC::Track>::iterator trit = myMeta.tracks.begin(); trit != myMeta.tracks.end(); trit++){ for (std::map<unsigned int, DTSC::Track>::iterator trit = myMeta.tracks.begin(); trit != myMeta.tracks.end(); trit++){
if ((!byType && trit->second.codec == strRef.substr(shift)) || (byType && trit->second.type == strRef.substr(shift)) || strRef.substr(shift) == "*"){ if ((!byType && trit->second.codec == strRef.substr(shift)) || (byType && trit->second.type == strRef.substr(shift)) || strRef.substr(shift) == "*"){
if (autoSeek && trit->second.lastms < seekTarget - 6000){continue;}
selectedTracks.insert(trit->first); selectedTracks.insert(trit->first);
found = true; found = true;
if (!multiSel){break;} if (!multiSel){break;}
@ -381,6 +398,12 @@ namespace Mist{
if (!selectedTracks.size() && myMeta.tracks.size() && capa["codecs"][bestSoFar].size()){ if (!selectedTracks.size() && myMeta.tracks.size() && capa["codecs"][bestSoFar].size()){
WARN_MSG("No tracks selected (%u total) for stream %s!", myMeta.tracks.size(), streamName.c_str()); WARN_MSG("No tracks selected (%u total) for stream %s!", myMeta.tracks.size(), streamName.c_str());
} }
bool madeChange = (oldSel != selectedTracks);
if (autoSeek && madeChange){
INFO_MSG("Automatically seeking to position %llu to resume playback", seekTarget);
seek(seekTarget);
}
return madeChange;
} }
/// Clears the buffer, sets parseData to false, and generally makes not very much happen at all. /// Clears the buffer, sets parseData to false, and generally makes not very much happen at all.
@ -825,7 +848,7 @@ namespace Mist{
if (buffer.size() != selectedTracks.size()){ if (buffer.size() != selectedTracks.size()){
std::set<uint32_t> dropTracks; std::set<uint32_t> dropTracks;
if (buffer.size() < selectedTracks.size()){ if (buffer.size() < selectedTracks.size()){
//prepare to drop any selectedTrack without buffe entry //prepare to drop any selectedTrack without buffer entry
for (std::set<unsigned long>::iterator it = selectedTracks.begin(); it != selectedTracks.end(); ++it){ for (std::set<unsigned long>::iterator it = selectedTracks.begin(); it != selectedTracks.end(); ++it){
bool found = false; bool found = false;
for (std::set<sortedPageInfo>::iterator bi = buffer.begin(); bi != buffer.end(); ++bi){ for (std::set<sortedPageInfo>::iterator bi = buffer.begin(); bi != buffer.end(); ++bi){

View file

@ -51,7 +51,7 @@ namespace Mist {
uint64_t endTime(); uint64_t endTime();
void setBlocking(bool blocking); void setBlocking(bool blocking);
void updateMeta(); void updateMeta();
void selectDefaultTracks(); bool selectDefaultTracks();
bool connectToFile(std::string file); bool connectToFile(std::string file);
static bool listenMode(){return true;} static bool listenMode(){return true;}
uint32_t currTrackCount() const; uint32_t currTrackCount() const;

View file

@ -28,6 +28,12 @@ namespace Mist {
} }
void OutJSON::sendNext(){ void OutJSON::sendNext(){
if (keepReselecting){
//If we can select more tracks, do it and continue.
if (selectDefaultTracks()){
return;//After a seek, the current packet is invalid. Do nothing and return here.
}
}
JSON::Value jPack = thisPacket.toJSON(); JSON::Value jPack = thisPacket.toJSON();
if (dupcheck){ if (dupcheck){
if (jPack.compareExcept(lastVal, nodup)){ if (jPack.compareExcept(lastVal, nodup)){

View file

@ -160,12 +160,9 @@ namespace Mist {
lastMeta = Util::epoch(); lastMeta = Util::epoch();
updateMeta(); updateMeta();
if (myMeta.tracks.size() > 1){ if (myMeta.tracks.size() > 1){
size_t prevTrackCount = selectedTracks.size(); if (selectDefaultTracks()){
selectDefaultTracks(); INFO_MSG("Track selection changed - resending headers and continuing");
if (selectedTracks.size() > prevTrackCount){
INFO_MSG("Picked up new track - selecting it and resetting state.");
sentHeader = false; sentHeader = false;
initialSeek();
return; return;
} }
} }