hydrar/mistserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Allow any RTP/AVP payload type to be dynamically assigned

Browse source 
The Bosch FLEXIDOME 4000i camera sets the RTP payload type to 35 for
H264, which causes MistServer to output "FAIL: Payload type 35 not
supported!"

The camera probably uses 35 for H264 because the ATSC standard requires
it. A/153 Part 7 states: [1]

> In addition, for RTP packets that carry AVC video elementary stream,
> the payload_type field in the RTP header shall have value 35.

The camera also sends "a=rtpmap:35 H264/90000" to explicitly map the
value 35 to H264. This is perfectly valid; although payload types 96
through 127 are recommended for dynamic use, the RTP protocol allows any
AVP payload type to be dynamically reassigned. The relevant section of
RFC 3551 states: [2]

> This profile reserves payload type numbers in the range 96-127
> exclusively for dynamic assignment.  Applications SHOULD first use
> values in this range for dynamic payload types.  Those applications
> which need to define more than 32 dynamic payload types MAY bind
> codes below 96, in which case it is RECOMMENDED that unassigned
> payload type numbers be used first.  However, the statically assigned
> payload types are default bindings and MAY be dynamically bound to
> new encodings if needed.  Redefining payload types below 96 may cause
> incorrect operation if an attempt is made to join a session without
> obtaining session description information that defines the dynamic
> payload types.

If the payload type is not recognized, assume that an rtpmap line will
follow that defines it. If in the end there is no rtpmap line, error out
in the same way whether the payload type is between 96 and 127 inclusive
or whether it is outside of that range.

[1] https://prdatsc.wpenginepowered.com/wp-content/uploads/2021/04/A153-Part-7-2012.pdf#page=14
[2] https://datatracker.ietf.org/doc/html/rfc3551#page-6
This commit is contained in:
Alex Henrie 2024-02-09 13:21:42 -07:00 • committed by Balder
parent 4e2d95961f
commit a1fbb9e186
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/sdp.cpp
View file

@ -596,14 +596,11 @@ namespace SDP{
// dynamic type // dynamic type
if (avp_type >= 96 && avp_type <= 127){ if (avp_type >= 96 && avp_type <= 127){
HIGH_MSG("Dynamic payload type (%" PRIu64 ") detected", avp_type); HIGH_MSG("Dynamic payload type (%" PRIu64 ") detected", avp_type);
}else{
HIGH_MSG("Payload type %" PRIu64 " not recognized. Assuming it's dynamic", avp_type);
}
nope = false; nope = false;
continue; continue;
}else{
FAIL_MSG("Payload type %" PRIu64 " not supported!", avp_type);
myMeta->removeTrack(tid);
tracks.erase(tid);
continue;
}
} }
} }
tConv[tid].setProperties(*myMeta, tid); tConv[tid].setProperties(*myMeta, tid);