hydrar/mistserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Correct handling of reaper thread in forking binaries

Browse source
This commit is contained in:
Thulinma 2021-04-21 17:56:16 +02:00
parent ddd9e8c67d
commit bffd81f27e
5 changed files with 33 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/util.cpp
View file

@ -245,8 +245,10 @@ namespace Util{
int pipeErr[2];
if (pipe(pipeErr) >= 0){
//Start reading log messages from the unnamed pipe
Util::Procs::fork_prepare();
pid_t pid = fork();
if (pid == 0) { //child
Util::Procs::fork_complete();
close(pipeErr[1]); // close the unneeded pipe file descriptor
//Close all sockets in the socketList
for (std::set<int>::iterator it = Util::Procs::socketList.begin(); it != Util::Procs::socketList.end(); ++it){
@ -264,6 +266,7 @@ namespace Util{
Util::logParser(pipeErr[0], true_stderr, isatty(true_stderr));
exit(0);
}
Util::Procs::fork_complete();
if (pid == -1){
FAIL_MSG("Failed to fork child process for log handling!");
}else{