hydrar/mistserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Prevent race condition when grim_reaper thread is already trying to lock while the thread is being asked to shut down

Browse source
This commit is contained in:
Thulinma 2024-01-19 15:53:10 +01:00
parent e20d8fae8c
commit d0374812e4
1 changed files with 24 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/procs.cpp
View file

@ -199,7 +199,7 @@ void Util::Procs::grim_reaper(void *n){
VERYHIGH_MSG("Grim reaper start"); VERYHIGH_MSG("Grim reaper start");
while (thread_handler){ while (thread_handler){
{ {
tthread::lock_guard<tthread::mutex> guard(plistMutex); if (plistMutex.try_lock()){
int status; int status;
pid_t ret = -1; pid_t ret = -1;
while (ret != 0){ while (ret != 0){
@ -223,6 +223,8 @@ void Util::Procs::grim_reaper(void *n){
HIGH_MSG("Child process %d exited with code %d", ret, exitcode); HIGH_MSG("Child process %d exited with code %d", ret, exitcode);
} }
} }
plistMutex.unlock();
}
} }
Util::sleep(500); Util::sleep(500);
} }